fix: accept Claude native trajectories - #52
Open
vincentkoc wants to merge 1 commit into
Open
Conversation
clawsweeper
Bot
added
rating: 🐚 platinum hermit
|
Codex review: needs maintainer review before merge. Reviewed August 4, 2026, 2:03 PM ET / 18:03 UTC. ClawSweeper reviewWhat this changesThe PR adds Claude Code to the native trajectory allowlist and tests that every pinned native harness reports real harness events. Merge readinessThe current default branch still omits Claude Code from real trajectory eligibility, while this focused member-authored PR directly repairs that mismatch with a regression assertion and supplied live native-run proof. It is ready for maintainer review rather than cleanup. Priority: P2 Review scores
Verification
How this fits togetherShellBench’s native runner records a manifest and trajectory for each harness run. Native aggregation consumes those fields to determine whether completed results are eligible for reporting. flowchart LR
A[Claude Code run] --> B[Native runner]
B --> C[Run manifest]
C --> D[Trajectory eligibility]
D --> E[Native aggregation]
E --> F[Reported results]
Decision needed
Why: The implementation and proof support the fix, but accepting the resulting reporting-cohort change is a maintainer decision. Before merge
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Merge the allowlist correction and regression test, then identify the forward-only eligibility change when comparing Claude Code result cohorts. Do we have a high-confidence way to reproduce the issue? Yes—current source shows that Claude Code is a pinned harness yet receives unsupported trajectory mode, and aggregation excludes that mode. The PR body also reports an after-fix four-task native run classified real. Is this the best way to solve the issue? Yes—the single allowlist entry matches the existing Claude Code stream-json trajectory writer, and the exhaustive harness assertion prevents this registry mismatch from recurring. AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against 884dd1bb5511. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (24 earlier review cycles; latest 8 shown)
|
vincentkoc
marked this pull request as ready for review
July 29, 2026 17:17
clawsweeper
Bot
added
proof: sufficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Marks Claude Code native trajectories as real harness events so completed Claude runs remain eligible for native aggregation.
Why?
The native runner already converts Claude Code
stream-jsonoutput intotrajectory.json, but the harness allowlist omittedclaude-code. Aggregation therefore classified otherwise valid Claude runs astrajectory_unavailable.Changes
claude-codeto the real-trajectory harness allowlistreal_harness_eventsLive proof
A native Claude Code control run completed four tasks with four result files, four valid completed results, and no infrastructure failures. Aggregation classified every trajectory as
real; the run remained ineligible only because it was intentionally marked as an exploratory four-task subset.4/40.753truerealfor all four tasks0exploratory_subsetTests
python -m pytest -qpasses locally (444 passed, 5 skipped)python -m ruff check clawbench app.py scripts testspasses locally